[OmniOS-discuss] [developer] Initial review --> Changes that allow illumos-gate to (mostly) build on OmniOS

[Dan McDonald]

> On Oct 24, 2014, at 11:56 AM, Josef 'Jeff' Sipek <jeffpc at josefsipek.net> wrote:
> 
> On Thu, Oct 23, 2014 at 09:56:30PM -0400, Dan McDonald via illumos-developer wrote:
>> 
>> * Some check_rtime modifications for the version of things in OmniOS
>> * Updates to allow buildings with openjdk7, but STILL ALLOW jdk1.6 that's on OI.
> 
> jdtrace/Makefile
> java_api/Makefile
> libdtrace_jni/java/Makefile
> 	you changed the -target from 1.5 to 1.6.  Is this right?  (FYI, I
> 	know nothing about Java.)

I did, because from what I can tell, OI uses 1.6 now.  OI's 1.6 is the earliest Java we support, from what I understand.

> damain/pools/Makefile
> 	does removing this change the output from 1.5 to 1.6?

Yes.

> dnssd/Makefile
> libdtrace_jni/java/Makefile
> 	I'm curious about the details here...  Javadoc uses different
> 	filenames for the generated gifs and this allows packaging to work
> 	since it'll see both old and new files?  Am I understanding
> 	correctly?  Would it make sense to document this hack in the package
> 	manifest as well for when someone decides that 1.6 is ancient?

openjdk7's javadoc generates other files, yes.  This hack does allow 1.6 and 1.7 to both work.  I probably should document it somewhere. I can't remember if pkg(5) files can take comments in the middle or not.

> A couple of the files have #pragma ident.

Yeah, should fix those pre-integration.

>> * Lose the IPP listener if so specified in your .env file, which depends on bits not in OmniOS.
> 
> Makefile
> 	Is this the only IPP related package?  Did the change a few years
> 	ago that introduced ENABLE_IPP_PRINTING not change any packaging?

ENABLE_IPP_PRINTING is NEW with this wad.

>> * Lose the dependency on docbooks, only existing in the Shell Style Guide.
> 
> Cool!  I think this also nukes one of the sources of wsdiff noise.

Even better!

>> * Lose the SMF dependency on sysidtool.
>> * Allow linkage with more recent versions of net-snmp.
>> * Lint fixes that the OmniOS sunstudio12.1 lint are picky about.
>> * More perl fixes to work with OmniOS's alternative approach to perl support.
> 
> Makefile.master
> 	Hrm?  Why are both -64int?  Is that right?  Ah, I see... you just
> 	moved it from Makefile.perl.  LGTM.

Phew.  And for building on OmniOS, you need to override that in your .env file.

>> Additionally, there's a sample .env file that anyone who applies these
>> fixes can use on their OmniOS build machine.  I also have a mail_msg from
>> an OmniOS build, to demonstrate what errors are still there in the build
>> even AFTER these changes.
>> 
>> I'd like both the illumos developer community and the OmniOS community to
>> look, and share their reviews and opinions.  If you have a distro that's
>> not OI or OmniOS, see if these mods help things work on YOUR distro.  If I
>> can get more non-OI distros to build or mostly-build stock illumos-gate,
>> it's better for everyone.
> 
> You said OI... did you try both /dev (151a9) as well as hipster?  Just
> curious.

I used /dev only (oi_151a9) for my tests.  I'd LOVE it if someone took these and tried on hipster.

Dan